Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move test scripts from 'package.json' to 'Taskfile' #1485

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: move test scripts from 'package.json' to 'Taskfile' #1485

wants to merge 14 commits into from

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Feb 25, 2025 •
edited
Loading

Description

Scripts related to running tests are moved from "scripts" inside the root package.json to the root Taskfile.yml

Related Issues

@instamenta instamenta self-assigned this Feb 25, 2025
@instamenta instamenta requested review from a team as code owners February 25, 2025 12:50
@instamenta instamenta linked an issue Feb 25, 2025 that may be closed by this pull request
move package.json scripts into Taskfile to clean it up and make it less complex #1073
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   62 suites  ±0   2s ⏱️ -1s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e55b3c6. ± Comparison against base commit 81c36bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   62 suites  ±0   3s ⏱️ -1s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e55b3c6. ± Comparison against base commit 81c36bd.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 25, 2025
@instamenta
disconnected taskfile example with the taskfile helper
6124dcf 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01073-move-packagejso…
ba62174 
…n-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex

# Conflicts:
#	.github/workflows/zxc-e2e-test.yaml
@instamenta
add non migrated piece of code
cbfd32c 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added PR: Checks Failed A pull request where the checks have failed. and removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. labels Feb 25, 2025
andrewb1269hg
andrewb1269hg approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve .yaml files assigned to Platform CI Team.

@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@rbarker-dev rbarker-dev Awaiting requested review from rbarker-dev rbarker-dev is a code owner automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@instamenta instamenta

Labels
PR: Checks Failed A pull request where the checks have failed. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move package.json scripts into Taskfile to clean it up and make it less complex
3 participants
@instamenta @andrewb1269hg @jeromy-cannon